Skip to content

feat: Relax cloud env check to support any non-empty MEMSCHEDULER_RAB… #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glin93 merged 1 commit into from
Dec 15, 2025
Merged

feat: Relax cloud env check to support any non-empty MEMSCHEDULER_RAB… #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/memos/mem_scheduler/general_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,7 @@ def _add_message_consumer(self, messages: list[ScheduleMessageItem]) -> None:
f"prepared_add_items: {prepared_add_items};\n prepared_update_items_with_original: {prepared_update_items_with_original}"
)
# Conditional Logging: Knowledge Base (Cloud Service) vs. Playground/Default
is_cloud_env = (
os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")
== "memos-memory-change"
)
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")

if is_cloud_env:
self.send_add_log_messages_to_cloud_env(
Expand Down Expand Up @@ -618,7 +615,7 @@ def _mem_feedback_message_consumer(self, messages: list[ScheduleMessageItem]) ->
f"Successfully processed feedback for user_id={user_id}, mem_cube_id={mem_cube_id}"
)

is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")
if is_cloud_env:
record = feedback_result.get("record") if isinstance(feedback_result, dict) else {}
add_records = record.get("add") if isinstance(record, dict) else []
Expand Down Expand Up @@ -896,9 +893,7 @@ def _process_memories_with_reader(

# LOGGING BLOCK START
# This block is replicated from _add_message_consumer to ensure consistent logging
is_cloud_env = (
os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
)
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")
if is_cloud_env:
# New: Knowledge Base Logging (Cloud Service)
kb_log_content = []
Expand Down Expand Up @@ -1018,9 +1013,7 @@ def _process_memories_with_reader(
f"Error in _process_memories_with_reader: {traceback.format_exc()}", exc_info=True
)
with contextlib.suppress(Exception):
is_cloud_env = (
os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
)
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")
if is_cloud_env:
if not kb_log_content:
trigger_source = (
Expand Down
2 changes: 1 addition & 1 deletion src/memos/mem_scheduler/task_schedule_modules/dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def _maybe_emit_task_completion(
mem_cube_id = first.mem_cube_id

try:
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME")
if not is_cloud_env:
return

Expand Down