Skip to content

fix: consistency of source_doc_id in mem_feedback and scheduler #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glin93 wants to merge 2 commits into from
Closed

fix: consistency of source_doc_id in mem_feedback and scheduler #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
530c942
fix: consistency of source_doc_id in mem_feedback and scheduler
Dec 9, 2025
3961e40
Merge branch 'dev' into fix/source-doc-id-consistency
glin93 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/memos/mem_feedback/feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,17 @@ def _pure_add(self, user_name: str, feedback_content: str, feedback_time: str, i
return {
"record": {
"add": [
{"id": _id, "text": added_mem.memory}
{
"id": _id,
"text": added_mem.memory,
"source_doc_id": (
added_mem.metadata.file_ids[0]
if hasattr(added_mem.metadata, "file_ids")
and isinstance(added_mem.metadata.file_ids, list)
and added_mem.metadata.file_ids
else None
),
}
for _id, added_mem in zip(added_ids, to_add_memories, strict=False)
],
"update": [],
Expand Down Expand Up @@ -197,7 +207,17 @@ def _single_add_operation(
)

logger.info(f"[Memory Feedback ADD] {added_ids[0]}")
return {"id": added_ids[0], "text": to_add_memory.memory}
return {
"id": added_ids[0],
"text": to_add_memory.memory,
"source_doc_id": (
to_add_memory.metadata.file_ids[0]
if hasattr(to_add_memory.metadata, "file_ids")
and isinstance(to_add_memory.metadata.file_ids, list)
and to_add_memory.metadata.file_ids
else None
),
}

def _single_update_operation(
self,
Expand Down Expand Up @@ -243,6 +263,13 @@ def _single_update_operation(
"text": new_memory_item.memory,
"archived_id": old_memory_item.id,
"origin_memory": old_memory_item.memory,
"source_doc_id": (
old_memory_item.metadata.file_ids[0]
if hasattr(old_memory_item.metadata, "file_ids")
and isinstance(old_memory_item.metadata.file_ids, list)
and old_memory_item.metadata.file_ids
else None
),
}

def _del_working_binding(self, user_name, mem_items: list[TextualMemoryItem]) -> set[str]:
Expand Down
4 changes: 2 additions & 2 deletions src/memos/mem_scheduler/general_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,8 @@ def _extract_fields(mem_item):
or mem_item.get("original_content")
)
source_doc_id = None
if "archived_id" in mem_item:
source_doc_id = mem_item.get("archived_id")
if isinstance(mem_item, dict):
source_doc_id = mem_item.get("source_doc_id")

return mem_id, mem_memory, original_content, source_doc_id

Expand Down