Skip to content

Feat/evaluation doc qa #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaralHsi merged 2 commits into from
Dec 7, 2025
Merged

Feat/evaluation doc qa #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbed950
fix: doc fine mode bug
CaralHsi Dec 7, 2025
20e0839
fix: doc fine mode bug
CaralHsi Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions src/memos/mem_reader/multi_modal_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,21 +377,37 @@ def _process_string_fine(
except Exception as e:
logger.error(f"[MultiModalFine] Error calling LLM: {e}")
continue
for m in resp.get("memory list", []):
if resp.get("memory list", []):
for m in resp.get("memory list", []):
try:
# Normalize memory_type (same as simple_struct)
memory_type = (
m.get("memory_type", "LongTermMemory")
.replace("长期记忆", "LongTermMemory")
.replace("用户记忆", "UserMemory")
)
# Create fine mode memory item (same as simple_struct)
node = self._make_memory_item(
value=m.get("value", ""),
info=info,
memory_type=memory_type,
tags=m.get("tags", []),
key=m.get("key", ""),
sources=sources, # Preserve sources from fast item
background=resp.get("summary", ""),
)
fine_memory_items.append(node)
except Exception as e:
logger.error(f"[MultiModalFine] parse error: {e}")
elif resp.get("value") and resp.get("key"):
try:
# Normalize memory_type (same as simple_struct)
memory_type = (
m.get("memory_type", "LongTermMemory")
.replace("长期记忆", "LongTermMemory")
.replace("用户记忆", "UserMemory")
)
# Create fine mode memory item (same as simple_struct)
node = self._make_memory_item(
value=m.get("value", ""),
value=resp.get("value", "").strip(),
info=info,
memory_type=memory_type,
tags=m.get("tags", []),
key=m.get("key", ""),
memory_type="LongTermMemory",
tags=resp.get("tags", []),
key=resp.get("key", None),
sources=sources, # Preserve sources from fast item
background=resp.get("summary", ""),
)
Expand Down
Loading