fix(sentinel): Re-raise exceptions in timed_with_status after logging/handl (#1679)#1831
Closed
Memtensor-AI wants to merge 1 commit into
Closed
fix(sentinel): Re-raise exceptions in timed_with_status after logging/handl (#1679)#1831Memtensor-AI wants to merge 1 commit into
Memtensor-AI wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated fix for #1679.
Analysis: Re-raise exceptions in timed_with_status after logging/handling so they propagate to callers for debugging.
Approach: In the timed_with_status method's exception handler, add a
raisestatement after any logging/status-setting logic so that exceptions are still propagated to the caller rather than being silently swallowed.Changes
src/memos/utils.pyCloses #1679
Generated by memos-sentinel