Skip to content

feat: add validation after parser installation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carloscalla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add validation after parser installation #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lua/treesitter-modules/core/manager.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ function M.init()
return
end
if M.config.auto_install and not M.installed:has(language) then
ts.install(language):await(function()
M.installed:add(language)
M.attach(buf, language)
ts.install(language):await(function(err)
Copy link
Owner

@MeanderingProgrammer MeanderingProgrammer Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what situations does installation fail? Is it for languages that don't have a parser or does it just sometimes happen?

Copy link
Author

@carloscalla carloscalla Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @MeanderingProgrammer sorry for the late reply. I experienced an error happening rarely one or two times before so I added this validation to attach only on success, which makes sense but doesn't really happen often.

if not err then
M.installed:add(language)
M.attach(buf, language)
end
end)
end
end,
Expand Down