🐛 Fix 70+ bugs, add DeathMessage module, fix 1.21.11 compatibility#230
Merged
Maxlego08 merged 2 commits intoMaxlego08:developfrom Mar 10, 2026
Merged
🐛 Fix 70+ bugs, add DeathMessage module, fix 1.21.11 compatibility#230Maxlego08 merged 2 commits intoMaxlego08:developfrom
Maxlego08 merged 2 commits intoMaxlego08:developfrom
Conversation
WhiteProject1
changed the title
Owner
|
You must do your PR in the develop branch and not manually, please change that, otherwise I will not accept your PR. |
Contributor
Author
|
Done, changed the base branch to |
Bug fixes (Wave 1-4): - Fix null player checks in 20+ commands (teleport, experience, give, trade, etc.) - Fix == vs .equals() comparisons for player objects in toggle commands - Fix wrong description/message enums in multiple commands - Fix economy NPE (null default economy, min/max swap, wrong reason enum) - Fix null sanction checks in SanctionModule, ZStorageManager, ButtonSanctions - Fix null user checks in autocomplete methods and placeholders - Fix player.isOnline() checks in delayed tasks (night vision) - Fix hologram module null check when NMS class not found - Fix InvseeListener null/offline target player - Add missing onlyPlayers() to CommandScoreboard, CommandTrade, CommandPayToggle - Add null module checks in commands that require modules New features: - DeathMessage module with 25+ purple-themed death cause messages - Per-player death message toggle (/deathmessage command) - Hover details showing death coordinates - Click-to-teleport suggestion on death messages Build fixes: - Fix adventure-text-serializer-ansi dependency resolution for NMS V1_21_8-11 - Add resolution strategy in allprojects for empty version BOM deps
- HologramLoader/Module: null check when NMS class unavailable (prevents plugin crash) - CommandEnchant: fallback for deprecated translationKey() - ZEnchantments: add LUNGE (1.21.11), null-safe register, use valueOf() for 1.21 enchants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onlyPlayers(),==vs.equals(), NPE guards)adventure-text-serializer-ansiempty version resolutiontranslationKey()fallbackBug Fixes
Null Safety (Wave 1-4)
getDefaultEconomy()NPE in CommandPayuser_has_discord_linkedplayer.isOnline()checks in delayed tasks (night vision)Logic Fixes
==vs.equals()for player object comparisons in toggle commandscompareTo > 0→>= 0in EconomyModulehasMoney()onlyPlayers()to CommandScoreboard, CommandTrade, CommandPayToggleHologram & 1.21.11 Compatibility
translationKey()valueOf()for 1.21 enchantsadventure-text-serializer-ansiempty version BOMNew: DeathMessage Module
/deathmessagecommandTest plan
/enchant lunge 1works/deathmessagetoggle