updated projects to dotnet9 + switched to incremental source generator#1
Merged
MaximTkachenko merged 7 commits intomainfrom Oct 13, 2025
Merged
Conversation
Owner
Author
|
There was a problem hiding this comment.
Pull Request Overview
Updates the solution to target .NET 9 and migrates the source generator from the classic ISourceGenerator model to an incremental IIncrementalGenerator while updating Roslyn and test/benchmark dependencies.
- Upgrade target frameworks (net5.0 -> net9.0) and dependency versions across projects
- Introduce incremental source generator pipeline and supporting launchSettings for debugging
- Adjust tests to instantiate the generated parser directly
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Parsers.Tests.csproj | Upgrades test project to .NET 9 and updates test dependencies. |
| test/ParserGeneratorTests.cs | Replaces reflective instantiation with direct construction of generated parser. |
| src/Parsers/Parsers.csproj | Upgrades runtime parser project framework and Roslyn dependency. |
| src/Parsers.SourceGenerator/Properties/launchSettings.json | Adds launch profile for debugging the source generator. |
| src/Parsers.SourceGenerator/Parsers.SourceGenerator.csproj | Updates analyzer/compiler packages and enables incremental generator-related build properties. |
| src/Parsers.SourceGenerator/ParserSourceGenerator.cs | Reimplements generator as an incremental generator and refactors symbol discovery logic. |
| benchmark/Parsers.Benchmarks.csproj | Upgrades benchmark project to .NET 9 and newer BenchmarkDotNet. |
| .github/workflows/dotnet.yml | CI updated to use .NET 9 SDK. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.