Open
Conversation
rocky
force-pushed
the
improve-numerator-denominator
branch
2 times, most recently
from
09efad1 to
f213a0f
Compare
Evaluate the expression before trying to pick out the numerator and denominator. Evaluation alter the expression form. If we get a number, then function calculation has to be based on that. Add Hacky test for Power involving an Integer.
rocky
force-pushed
the
improve-numerator-denominator
branch
from
f213a0f to
58bf512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluate the expression before trying to pick out the numerator and denominator. Evaluation alters the expression form. If we get a number, then the function calculation has to be based on that.
Add Hacky test for Power involving an Integer.