Skip to content

<feat>[sdk]: add requestCpu and add errCode#3546

Open
ZStack-Robot wants to merge 1 commit into5.5.12from
sync/zhong.xian/ZSTAC-80103@@2
Open

<feat>[sdk]: add requestCpu and add errCode#3546
ZStack-Robot wants to merge 1 commit into5.5.12from
sync/zhong.xian/ZSTAC-80103@@2

Conversation

@ZStack-Robot
Copy link
Collaborator

add requestCpuNum and requestMemorySize;
add loudOperationsErrorCode

Resolves: ZSTAC-80103

Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0

sync from gitlab !9405

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 609dfdc9-5736-451a-b54a-0a139ea4aa80

📥 Commits

Reviewing files that changed from the base of the PR and between b3b0277 and b14810b.

⛔ Files ignored due to path filters (5)
  • sdk/src/main/java/org/zstack/sdk/DeployAppDevelopmentServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/DeployModelEvalServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/DeployModelServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/MatchModelServiceTemplateWithModelAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/ModelService.java is excluded by !sdk/**
📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
✅ Files skipped from review due to trivial changes (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Walkthrough

CloudOperationsErrorCode 类中新增了七个公共静态错误代码常量:ORG_ZSTACK_AI_10135ORG_ZSTACK_AI_10141。未修改或删除现有常量,也未改变控制流或逻辑。

Changes

Cohort / File(s) Summary
错误代码常量
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
添加七个新的 public static final String 常量:ORG_ZSTACK_AI_10135ORG_ZSTACK_AI_10141

Estimated code review effort

🎯 1 (微不足道) | ⏱️ ~2 分钟

Poem

🐰✨ 新代码入列声欢腾,
七枚标识排成行,
追踪错误更分明,
小耳摆动喜洋洋,
兔儿轻跳庆贺忙。

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed 标题格式正确,符合 [scope]: 规范,长度为 43 字符,未超过 72 字符限制。
Description check ✅ Passed 描述与变更集相关,提到了添加错误代码,与PR中添加的 ORG_ZSTACK_AI_10135-10141 常量相符。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zhong.xian/ZSTAC-80103@@2
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.41.1)
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix MatheMatrix force-pushed the sync/zhong.xian/ZSTAC-80103@@2 branch from 0427456 to b3b0277 Compare March 19, 2026 15:38
@MatheMatrix
Copy link
Owner

Comment from zhong.xian:

@coderabbitai help

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Tip

For best results, initiate chat on the files or code changes.

@MatheMatrix: 您好!以下是 CodeRabbit 支持的主要命令和功能介绍:


CodeRabbit 使用帮助

💬 评论指令

在 PR 评论中,您可以使用以下指令与 CodeRabbit 交互:

指令 描述
@coderabbitai review 触发对 PR 的完整审查
@coderabbitai full review 重新对所有文件进行完整审查
@coderabbitai summary 重新生成 PR 摘要
@coderabbitai resolve 解决 CodeRabbit 在 PR 中的所有评论
@coderabbitai approve 批准 PR 中的更改
@coderabbitai pause 暂停 PR 的自动审查
@coderabbitai resume 恢复 PR 的自动审查
@coderabbitai help 显示此帮助信息

💡 在代码行评论中

您可以直接在代码行上进行评论,向 CodeRabbit 提问或请求操作,例如:

  • 解释某段代码的逻辑
  • 生成单元测试
  • 请求代码优化建议
  • 询问潜在的 Bug

🔧 配置 CodeRabbit

您可以通过在仓库根目录创建 .coderabbit.yaml 文件来自定义 CodeRabbit 的行为,例如:

  • 设置审查语言
  • 配置路径过滤规则
  • 提供特定的审查指导

更多配置信息请参考:CodeRabbit 文档


如需针对此 PR(添加 requestCpuNumrequestMemorySize 及错误码 ORG_ZSTACK_AI_10135 ~ ORG_ZSTACK_AI_10141)进行审查,请回复 @coderabbitai review

add requestCpuNum and requestMemorySize;
add loudOperationsErrorCode

Resolves: ZSTAC-80103

Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0
@MatheMatrix MatheMatrix force-pushed the sync/zhong.xian/ZSTAC-80103@@2 branch from b3b0277 to b14810b Compare March 19, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants