console: only surface oidc auth errors from active sign-in attempts#36879
Open
leedqin wants to merge 1 commit into
Open
console: only surface oidc auth errors from active sign-in attempts#36879leedqin wants to merge 1 commit into
leedqin wants to merge 1 commit into
Conversation
Auth errors were sticky on the login page across refresh and back navigation. Switched the url param to a sessionStorage key that login component reads and removes on mount so the error doesn't persist on reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth errors were sticky on the login page across refresh and back navigation. Switched the url param to a sessionStorage key that login component reads and removes on mount so the error doesn't persist on reload.
Remove these sections if your commit already has a good description!
Motivation
Fixes CNS-88
Description
What does this PR actually do? Focus on the approach and any non-obvious
decisions. The diff shows the code --- use this space to explain what the
diff can't tell a reviewer.
Verification
Before the fix error keeps persisting:
err_persisting.mov
After fix error doesn't persist on refresh:
error_persistence.mov