Skip to content

mz-test: note CI=1 trap, --optimized#36867

Open
ggevay wants to merge 1 commit into
MaterializeInc:mainfrom
ggevay:mz-test-tweak-1
Open

mz-test: note CI=1 trap, --optimized#36867
ggevay wants to merge 1 commit into
MaterializeInc:mainfrom
ggevay:mz-test-tweak-1

Conversation

@ggevay
Copy link
Copy Markdown
Contributor

@ggevay ggevay commented Jun 2, 2026

Make the testing skill mention some gotchas in how to run testdrive:

  • use --optimized in the canonical command;
  • unset CI=1, which was auto-set in my Junie env (RustRover's AI agent), creating some confusion;
  • argument ordering.

Co-authored-by: Junie <junie@jetbrains.com>
@ggevay ggevay requested a review from def- June 2, 2026 13:14
@ggevay ggevay added the T-testing Theme: tests or test infrastructure label Jun 2, 2026
Comment on lines +59 to +60
If `CI=1` is set in your shell (agent runtimes such as Junie export
it by default for unattended-mode hygiene), `mzcompose` will refuse to build
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! Why does Junie set CI=1 if it's not running in CI?


```
bin/mzcompose --find testdrive run default -- FILENAME.td
bin/mzcompose --optimized --find testdrive run default -- FILENAME.td
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default already, why do we need to specify it explicitly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-testing Theme: tests or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants