CLO-81 cancel rollout after timeout#36863
Open
alex-hunt-materialize wants to merge 1 commit into
Open
Conversation
alex-hunt-materialize
force-pushed
the
CLO-81_cancel_deploy_after_timeout
branch
2 times, most recently
from
b007c3f to
f8c5b07
Compare
alex-hunt-materialize
force-pushed
the
CLO-81_cancel_deploy_after_timeout
branch
from
f8c5b07 to
26db895
Compare
Contributor
Author
|
@bosconi Did you get the distribution of actual times? I wrote this with 24h timeout, but I'd like to confirm that's the appropriate number before we merge. |
doy-materialize
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel rollout after timeout exceeded.
Motivation
Resolves https://linear.app/materializeinc/issue/CLO-81/deploy-should-cancel-environment-rollout-after-a-configurable-timeout
Description
Adds a new
rollout_request_timeoutfield to the Materialize CRD, with a default of 24 hours. If the rollout runs for longer than that time, it gets aborted.There is a significant change to the timestamp of the UpToDate condition. We now track its last transition time as when the value changes, not every time the reason changes. I don't think this affects anything else, but I think this is actually closer to how most K8S things use this field, and it's required to not reset the timer.
Verification
New rust tests, and new orchestratord nightly test.