Fix panic when attempting to set default_timestamp_interval to 0#36853
Open
peterdukelarsen wants to merge 3 commits into
Open
Fix panic when attempting to set default_timestamp_interval to 0#36853peterdukelarsen wants to merge 3 commits into
peterdukelarsen wants to merge 3 commits into
Conversation
ublubu
approved these changes
Jun 2, 2026
Contributor
ublubu
left a comment
ublubu
left a comment
There was a problem hiding this comment.
Looks good. It does give me a new question, though. (inline)
Comment on lines
+127
to
+131
| if d.is_zero() { | ||
| Err(VarError::InvalidParameterValue { | ||
| name: var.name(), | ||
| invalid_values: vec![format!("{:?}", d)], | ||
| reason: "only supports durations greater than zero".to_string(), |
Contributor
There was a problem hiding this comment.
It looks a little weird to is_zero() and then say greater than zero. I had to double-check that Duration can't be negative 😅
| simple conn=mz_system,user=mz_system | ||
| ALTER SYSTEM SET default_timestamp_interval = '-1'; | ||
| ---- | ||
| db error: ERROR: parameter "default_timestamp_interval" requires a "duration" value |
Contributor
There was a problem hiding this comment.
I realize this isn't a regression, but this error message is interesting, especially given that the above tests use values like 1 and 0, which don't appear to be durations either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes ss-147
Description
Adds a non-zero constraint to the "default_timestamp_interval" system parameter. This prevents an issue where setting it to 0 causes a panic and the database won't start up until you go in and update the parameter by different means.
Verification
ALTER ...statement is issued