refactor: Change all Visitors to be iterative, child-based#36852
Draft
mgree wants to merge 2 commits into
Draft
Conversation
mgree
force-pushed
the
mir-visitor-iterative
branch
2 times, most recently
from
4947ffe to
9b39e43
Compare
mgree
force-pushed
the
mir-visitor-iterative
branch
from
9b39e43 to
9ab62e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#36759 (comment)
Description
Changes
VisitChildrento havechildren()andchildren_mut()functions.Changes
Visitorto use these for iterative traversals.NB that mutable post-traversal requires unsafety: we need an
&mutfor the children and an&mutfor the parent when we're done. This is sound---Rust allows it when your stack is the call stack, but not your own data structure. So: this is somewhat unsavory code.Verification
Green CI.
NB maintaing safety in
VisitChildrenmeans slightly changing visit order: if we're going to work viachildren_mut(), we can no longer yield all subqueries before the term itself. This seems to have affected precisely one SLT, which I've rewritten.