Remove 7 stale LaunchDarkly feature flags permanently on#36080
Open
Remove 7 stale LaunchDarkly feature flags permanently on#36080
Conversation
Remove feature flags that have been uniformly enabled in production for 1-3 years with no individual targeting, hardcoding their "on" behavior: - `enable_multi_worker_storage_persist_sink` (on since 2023-05, dead code) - `persist_pubsub_client_enabled` (on since 2023-06) - `persist_pubsub_push_diff_enabled` (on since 2023-06) - `storage_dataflow_delay_sources_past_rehydration` (on since 2023-10) - `persist_optimize_ignored_data_fetch` (on since 2024-05) - `enable_lgalloc_eager_reclamation` (on since 2024-02) - `use_global_txn_cache_source` (on since 2024-05, no Rust references) https://claude.ai/code/session_01BnvkhW8217L1E3e1sMAarQ
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ggevay
approved these changes
Apr 15, 2026
Contributor
ggevay
left a comment
There was a problem hiding this comment.
(LGTM from the Adapter side)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 7 LaunchDarkly boolean feature flags that have been uniformly enabled
in production (no individual targeting) for 1–3 years, hardcoding their
"on" behavior:
enable_multi_worker_storage_persist_sinkpersist_pubsub_client_enabledpersist_pubsub_push_diff_enabledstorage_dataflow_delay_sources_past_rehydrationenable_lgalloc_eager_reclamationpersist_optimize_ignored_data_fetchuse_global_txn_cache_sourceHow these were identified: Queried the LaunchDarkly API for all boolean
flags in the
productionenvironment that areon, have no individualtargeting rules, and whose targeting was last modified more than 3 months ago.
Then verified each flag's codebase references to confirm safe removal.
Changes
branches — the "true" code path is now unconditional
mzcomposedefaults,UNINTERESTING_SYSTEM_PARAMETERS,parallel_workloadflag lists, andredundant test overrides in
test/upsert/mzcompose.pycompute-types/dyncfgs.mdTest plan
cargo checkpasses for all modified crates (mz-persist-client,mz-storage-types,mz-compute-types,mz-sql,mz-compute,mz-storage)https://claude.ai/code/session_01BnvkhW8217L1E3e1sMAarQ