Skip to content

Remove PR checklist bot workflow#36063

Merged
antiguru merged 2 commits intoMaterializeInc:mainfrom
antiguru:mh/remove-pr-checklist-bot
Apr 15, 2026
Merged

Remove PR checklist bot workflow#36063
antiguru merged 2 commits intoMaterializeInc:mainfrom
antiguru:mh/remove-pr-checklist-bot

Conversation

@antiguru
Copy link
Copy Markdown
Member

Nobody reads the automated PR comment — it's noise.
The same guidance (PR title conventions, test coverage, design docs, proto labels, cloud companion PRs) lives in doc/developer/guide-changes.md and is enforced through code review.

🤖 Generated with Claude Code

Nobody reads the automated PR comment — it's noise.
The same guidance (PR title conventions, test coverage, design docs,
proto labels, cloud companion PRs) lives in doc/developer/guide-changes.md
and is enforced through code review.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@antiguru antiguru requested a review from a team as a code owner April 14, 2026 08:14
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def-
Copy link
Copy Markdown
Contributor

def- commented Apr 14, 2026

I always use the "trigger-ci for additional test/nightly runs"

@def- def- requested a review from aljoscha April 14, 2026 08:32
@aljoscha
Copy link
Copy Markdown
Contributor

I always use the "trigger-ci for additional test/nightly runs"

I also use that link a lot, is there maybe a good way we can add a button right in github (I know you can set up a bookmark to do that, but then everyone has to do that themselves...). But other than that I'd be in favor of removing the message!

@def-
Copy link
Copy Markdown
Contributor

def- commented Apr 15, 2026

We could use a github status for that, it's slightly more hidden. Added a commit for it. Here's a demo of how it looks for Vercel:

Screen.Recording.2026-04-15.at.14.34.03.mov

@def- def- force-pushed the mh/remove-pr-checklist-bot branch from 9125cc6 to 15acd80 Compare April 15, 2026 06:39
@antiguru
Copy link
Copy Markdown
Member Author

We could use a github status for that

Neat! It seems github sorts the checks alphabetically, so we could pick a name that sorts earlier.

@def-
Copy link
Copy Markdown
Contributor

def- commented Apr 15, 2026

Yes, I also just realized that, so using "A" now :D

@antiguru antiguru merged commit 36b6082 into MaterializeInc:main Apr 15, 2026
5 checks passed
@antiguru antiguru deleted the mh/remove-pr-checklist-bot branch April 15, 2026 06:49
@def-
Copy link
Copy Markdown
Contributor

def- commented Apr 15, 2026

Screenshot 2026-04-15 at 15 07 32 Works. I didn't realize the "CI Trigger Link" will also show up though, I'll remove that and create the GH status from Buildkite's side instead.

def- added a commit to def-/materialize that referenced this pull request Apr 15, 2026
def- added a commit to def-/materialize that referenced this pull request Apr 15, 2026
def- added a commit to def-/materialize that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants