compute/correction_v2: make chunk capacity configurable#36046
Merged
teskje merged 3 commits intoMaterializeInc:mainfrom Apr 15, 2026
Merged
compute/correction_v2: make chunk capacity configurable#36046teskje merged 3 commits intoMaterializeInc:mainfrom
teskje merged 3 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
teskje
force-pushed
the
chunk-size-dyncfg
branch
from
eda7427 to
a066b91
Compare
This moves the `merge_*` functions into the `CorrectionV2` impl block, in preparation of making them methods. This is pure code movement, to simplify code review. The code is left in a broken state and is fixed in the next commit.
Previously, `CorrectionV2` used `TimelyStack`'s default capacity (8KiB) for the `Chunk` capacity. We suspect that this size is smaller than ideal and would like a way to experiment with different values in production. This commit makes the chunk capacity configurable through a dyncfg. Like the chain proportionality, changes to this configuration only take effect when a `CorrectionV2` instance is created.
teskje
force-pushed
the
chunk-size-dyncfg
branch
from
a066b91 to
c31814d
Compare
antiguru
reviewed
Apr 15, 2026
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good, but I'd like to see the use of SizableContainer to go away.
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
CorrectionV2usedTimelyStack's default capacity (8KiB) for theChunkcapacity. We suspect that this size is smaller than ideal and would like a way to experiment with different values in production.This commit makes the chunk capacity configurable through a dyncfg. Like the chain proportionality, changes to this configuration only take effect when a
CorrectionV2instance is created.First commit is pure code movement, to simplify the review of the logic changes in the second commit.