Fix fast-path plan creation to be mindful of the finishing's offset#36044
Open
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Open
Fix fast-path plan creation to be mindful of the finishing's offset#36044ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ggevay
force-pushed
the
fix-fast-path-finishing-offset
branch
from
96961ce to
bbcdeb9
Compare
antiguru
reviewed
Apr 14, 2026
Comment on lines
+475
to
+477
| i128::cast_from(l) | ||
| >= i128::cast_from(*finishing_limit) | ||
| + i128::cast_from(finishing.offset) |
Member
There was a problem hiding this comment.
What's the benefit of using u128 over finishing_limit.saturating_add(finishing.offset)?
Contributor
Author
There was a problem hiding this comment.
If l is exactly equal to i64::max, then the saturating_add capping the right-hand side down to also i64::max could result in a false positive detection, no? (I think this bug couldn't actually manifest, because our Diff type is also i64, but we better not rely on that here.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MaterializeInc/database-issues/issues/11292