Open
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
antiguru
force-pushed
the
claude/remove-continual-tasks-akICD
branch
from
e9990a5 to
9187f22
Compare
antiguru
requested review from
SangJunBak,
aljoscha and
teskje
and removed request for
a team and
aljoscha
Contributor
Contributor
|
I'd like to see a platform check that creates a CT if the version is old enough to allow it and then checks that we handle the migration properly, could be done with the existing tests in misc/python/materialize/checks/all_checks/continual_task.py |
antiguru
force-pushed
the
claude/remove-continual-tasks-akICD
branch
from
4a2664a to
b36e831
Compare
teskje
reviewed
Apr 15, 2026
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
Got halfway through, but need to get lunch now!
antiguru
force-pushed
the
claude/remove-continual-tasks-akICD
branch
2 times, most recently
from
3a75b2c to
8e95b61
Compare
Remove the continual tasks feature from Materialize. CTs were an experimental feature that is no longer needed. Changes: * Remove CT SQL syntax from parser * Remove CT catalog items, builtins, and system tables * Remove CT rendering in compute * Add catalog migration v81→v82 that panics if CTs are found * Remove BuiltinsConfig (empty after CT removal) * Add platform check for CT migration verification * Clean up related comments and dead code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
antiguru
force-pushed
the
claude/remove-continual-tasks-akICD
branch
from
8e95b61 to
e80bd1d
Compare
teskje
reviewed
Apr 16, 2026
Contributor
There was a problem hiding this comment.
This reverts parts of #36032. Worth double-checking if other merge skew made it in as well.
teskje
reviewed
Apr 16, 2026
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
Looks good, except for the merge skew!
| { | ||
| self.parse_create_materialized_view() | ||
| .map_parser_err(StatementKind::CreateMaterializedView) | ||
| } else if self.peek_keywords(&[CONTINUAL, TASK]) { |
Contributor
There was a problem hiding this comment.
Anything we can delete from keywords.txt now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectType::ContinualTaskfor backward compatibility with persisted entriesDetails
Catalog migration (v81→v82):
create_sqlstarts withCREATE CONTINUAL TASKBUILTINS_STATIC)What was removed (~4,600 lines deleted across 99 files):
CREATE/DROP/SHOW/ALTER/COMMENT ON CONTINUAL TASKsyntax,ContinualTaskStmt,CreateContinualTaskSugar(TRANSFORM/RETAIN)CreateContinualTaskPlan, feature flags (enable_continual_task_create/transform/retain),max_continual_taskssession var,CatalogItemType::ContinualTask,ObjectType::ContinualTask,CommentObjectId::ContinualTasksequence_create_continual_task, CT bootstrap/dataflow logic, CT quota checks,ExecuteResponse::CreatedContinualTaskContinualTaskCtx,ContinualTaskConnection, CT sink rendering,render/continual_task.rsBuiltinContinualTask, 3 system CTs (mz_cluster_replica_metrics_history_ct,mz_cluster_replica_status_history_ct,mz_wallclock_lag_history_ct),mz_continual_taskstable/view/indexesBuiltinsConfigemptied (was only used forinclude_continual_tasks);BUILTINS::iter()no longer takes a config parameterWhat was preserved:
mz_audit_log::ObjectType::ContinualTask— audit log entries are immutableaudit_log_event_v1::ObjectType::ContinualTaskin catalog protos — same reasonhttps://claude.ai/code/session_01Rx3uSReMsvp3zDTxnXuNUd