tooling: Speed up bin/lint (26s to 16s on my system, way less CPU used) & live output#35400
Merged
def- merged 2 commits intoMaterializeInc:mainfrom Mar 13, 2026
Merged
tooling: Speed up bin/lint (26s to 16s on my system, way less CPU used) & live output#35400def- merged 2 commits intoMaterializeInc:mainfrom
def- merged 2 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
def-
changed the title
def-
force-pushed
the
pr-lint-speedups
branch
5 times, most recently
from
c0afb41 to
5758e0b
Compare
Contributor
Author
|
Ready for review |
check-whitespace.sh: 24s -> 1s check-protobuf.sh: 19s -> 3s check-mzcompose-files.sh: 18s -> 4s check-copyright.sh: 14s -> 0.4s check-rust-test-attributes.sh: 8s -> 0.2s Main blocker is pyright now, but unfortunately Astral's ty doesn't seem up to the task yet.
def-
changed the title
bosconi
approved these changes
Mar 13, 2026
Member
bosconi
left a comment
bosconi
left a comment
There was a problem hiding this comment.
Looks good. Huge improvements! Python and fewer processes for the win it would seem.
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
…d) & live output (MaterializeInc#35400) ``` check-whitespace.sh: 24s -> 1s check-protobuf.sh: 19s -> 3s check-mzcompose-files.sh: 18s -> 4s check-copyright.sh: 14s -> 0.4s check-rust-test-attributes.sh: 8s -> 0.2s check-python-files.sh: 17s -> 14s ``` Main blocker is pyright now, but unfortunately Astral's ty doesn't seem up to the task yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main blocker is pyright now, but unfortunately Astral's ty doesn't seem up to the task yet.