COPY FROM s3: remove redundant non-null check from planning#35399
Merged
patrickwwbutler merged 1 commit intoMaterializeInc:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
…izeInc#35399) Fixes a bug where if you have `NON NULL` columns in your target table, then you have to manually specify all columns, leading to clunk UX. The non null check here is redundant as we are validating every row during ingestion as well, so any null constraint violations would be caught there. ### Motivation [Addresses a client question here](https://materializeinc.slack.com/archives/C09DEL5PRL2/p1773150336885249?thread_ts=1773150318.948489&cid=C09DEL5PRL2) ### Verification Added a new test case to testdrive to cover this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if you have
NON NULLcolumns in your target table, then you have to manually specify all columns, leading to clunk UX. The non null check here is redundant as we are validating every row during ingestion as well, so any null constraint violations would be caught there.Motivation
Addresses a client question here
Verification
Added a new test case to testdrive to cover this