http: stream WebSocket rows instead of buffering#35394
Merged
antiguru merged 1 commit intoMaterializeInc:mainfrom Mar 10, 2026
Merged
http: stream WebSocket rows instead of buffering#35394antiguru merged 1 commit intoMaterializeInc:mainfrom
antiguru merged 1 commit intoMaterializeInc:mainfrom
Conversation
Previously, `WebSocket::add_result` collected all result rows into a `Vec<WebSocketResponse>` before sending any. Each enum instance is sized to the largest variant (~150 bytes for Error/Notice), but Row only needs ~24 bytes. For large result sets this caused substantial memory overhead. Stream rows directly over the websocket as they're produced, matching how the Subscribe path already works. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
aljoscha
approved these changes
Mar 10, 2026
Contributor
aljoscha
left a comment
aljoscha
left a comment
There was a problem hiding this comment.
Looks fine, if ci likes it we are good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
WebSocket::add_resultcollected all result rows into aVec<WebSocketResponse>before sending any over the wire.Each enum instance is sized to the largest variant (~150 bytes for
Error/Notice), butRowonly needs ~24 bytes.For large result sets this caused substantial memory overhead.
Stream rows directly over the websocket as they're produced, matching how the
Subscribepath already works.🤖 Generated with Claude Code