Skip to content

fix bad join condition in console cluster list#35264

Merged
jubrad merged 1 commit intoMaterializeInc:mainfrom
jubrad:fix/console-cluster-list-join
Mar 3, 2026
Merged

fix bad join condition in console cluster list#35264
jubrad merged 1 commit intoMaterializeInc:mainfrom
jubrad:fix/console-cluster-list-join

Conversation

@jubrad
Copy link
Contributor

@jubrad jubrad commented Mar 1, 2026

I was looking through console code to see if we could simplify any of our json queries and found this. Pretty sure it's a bug. .

@jubrad jubrad requested a review from a team as a code owner March 1, 2026 20:45
@jubrad jubrad requested review from SangJunBak and removed request for a team March 1, 2026 20:45
@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@jubrad jubrad requested a review from leedqin March 1, 2026 20:45
Copy link
Contributor

@leedqin leedqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubrad jubrad force-pushed the fix/console-cluster-list-join branch 3 times, most recently from bd9efc9 to 0f5f26c Compare March 2, 2026 21:55
@jubrad jubrad enabled auto-merge (squash) March 2, 2026 21:55
@jubrad jubrad force-pushed the fix/console-cluster-list-join branch from 0f5f26c to 5ccfc99 Compare March 3, 2026 02:31
@jubrad jubrad force-pushed the fix/console-cluster-list-join branch from 5ccfc99 to 461cc6d Compare March 3, 2026 02:54
@jubrad jubrad merged commit 30058ee into MaterializeInc:main Mar 3, 2026
119 checks passed
@jubrad jubrad deleted the fix/console-cluster-list-join branch March 3, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants