sql: post repr types: Rename output_type() to output_sql_type() on all scalar funcs #35219
Merged
ggevay merged 6 commits intoMaterializeInc:mainfrom Feb 27, 2026
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ggevay
force-pushed
the
repr-type-canonicalize-xform-rename-output-type
branch
from
cb7e9c7 to
4d0d81f
Compare
ggevay
added a commit
that referenced
this pull request
Feb 26, 2026
… MIR structs (#35084) This is pushing on the repr types work stream. It's on top of #35067, and stealing stuff from #35073. The "Add soft_panic_or_log! canaries for repr type mismatches" commit turns some error logs into soft_panics, and the other commits attempt to make CI not run into any of these panics. Nightlies: - https://buildkite.com/materialize/nightly/builds/15255 (stale) - https://buildkite.com/materialize/nightly/builds/15259 (stale) - https://buildkite.com/materialize/nightly/builds/15260 (stale) - https://buildkite.com/materialize/nightly/builds/15296 (stale) - https://buildkite.com/materialize/nightly/builds/15337 (stale) - https://buildkite.com/materialize/nightly/builds/15346 (stale) - https://buildkite.com/materialize/nightly/builds/15350 (stale) - https://buildkite.com/materialize/nightly/builds/15351 (stale) - https://buildkite.com/materialize/nightly/builds/15355 (limited to RQGs + SLTs) - https://buildkite.com/materialize/nightly/builds/15358 (stale) - https://buildkite.com/materialize/nightly/builds/15359 (slightly stale) - https://buildkite.com/materialize/nightly/builds/15366 Release qualifications: - https://buildkite.com/materialize/release-qualification/builds/1115 (slightly stale) #35219 does some naming/cleanup that we'll keep separate (since it involves touching the `*Func` macros). --------- Co-authored-by: Michael Greenberg <michael.greenberg@materialize.com>
ggevay
force-pushed
the
repr-type-canonicalize-xform-rename-output-type
branch
from
4d0d81f to
b027da8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup stacked on #35084. Edit: That one is merged.
Description
The various scalar functions compute their SQL output types given SQL input types. This renames functions to clarify and adds a shim that converts repr types up to canonical SQL types and then converts the resulting SQL type back to a repr type.
Verification
All the tests.