Skip to content

Comments

[mz-dump] custom queries and daily usage#35200

Merged
sjwiesman merged 2 commits intoMaterializeInc:mainfrom
sjwiesman:daily_credit_usage
Feb 24, 2026
Merged

[mz-dump] custom queries and daily usage#35200
sjwiesman merged 2 commits intoMaterializeInc:mainfrom
sjwiesman:daily_credit_usage

Conversation

@sjwiesman
Copy link
Contributor

Motivation

Support for custom queries in the catalog dump along with a specific query to grab materialize usage over time.

Description

What does this PR actually do? Focus on the approach and any non-obvious
decisions. The diff shows the code --- use this space to explain what the
diff can't tell a reviewer.

Verification

How do you know this change is correct? Describe new or existing automated
tests, or manual steps you took.

@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. I'm not good at SQL, though, so you probably want a second opinion on that part.

The one thing I caution you about here, is if this relation takes significant memory, you may end up OOMing environmentd. This is extra likely as we're probably running against a broken environment which may have very little free memory. This is probably acceptable in this case, but something to keep in mind.

@sjwiesman sjwiesman enabled auto-merge (squash) February 24, 2026 17:16
@sjwiesman sjwiesman disabled auto-merge February 24, 2026 17:34
@sjwiesman sjwiesman enabled auto-merge (squash) February 24, 2026 17:59
@sjwiesman sjwiesman merged commit 44d569e into MaterializeInc:main Feb 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants