[cluster] Update collection for subscribe results#35055
Draft
bkirwi wants to merge 5 commits intoMaterializeInc:mainfrom
Draft
[cluster] Update collection for subscribe results#35055bkirwi wants to merge 5 commits intoMaterializeInc:mainfrom
bkirwi wants to merge 5 commits intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
bkirwi
force-pushed
the
update-collection
branch
3 times, most recently
from
0eb840c to
4d52aec
Compare
I've implemented this or similar a few times now... time to share.
bkirwi
force-pushed
the
update-collection
branch
from
4d52aec to
6a9c673
Compare
bkirwi
force-pushed
the
update-collection
branch
from
6a9c673 to
36909bc
Compare
This lets us remove some implementation, including some unsafe.
bkirwi
force-pushed
the
update-collection
branch
from
36909bc to
8ecab5a
Compare
This code previously resorted and reallocated data in ~all cases. We now do more or less the minimum for the given subscribe format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.