Skip to content

storage: make reclock to latest the only reclock variant#35046

Merged
petrosagg merged 4 commits intoMaterializeInc:mainfrom
petrosagg:commmit-to-rlu
Feb 25, 2026
Merged

storage: make reclock to latest the only reclock variant#35046
petrosagg merged 4 commits intoMaterializeInc:mainfrom
petrosagg:commmit-to-rlu

Conversation

@petrosagg
Copy link
Contributor

@petrosagg petrosagg commented Feb 17, 2026 •
edited
Loading

The old strategy of reclocking to whatever upper we have consumed is no longer used. This PR deletes the relevant code paths and simplifies the SourceRender trait.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@petrosagg petrosagg marked this pull request as ready for review February 17, 2026 13:51
@petrosagg petrosagg requested a review from a team as a code owner February 17, 2026 13:51
@petrosagg petrosagg requested a review from martykulma February 19, 2026 09:28
teskje
teskje approved these changes Feb 24, 2026
View reviewed changes
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

src/storage/src/source/mysql/replication.rs Outdated
@@ -40,7 +40,7 @@
//! (at the minimum timestamp) and send it again at the correct GTID.

use std::collections::BTreeMap;
use std::convert::Infallible;

Copy link
Contributor

@teskje teskje Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/storage/src/source/sql_server/replication.rs Outdated
@@ -10,7 +10,7 @@
//! Code to render the ingestion dataflow of a [`SqlServerSourceConnection`].

use std::collections::{BTreeMap, BTreeSet};
use std::convert::Infallible;

Copy link
Contributor

@teskje teskje Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

martykulma
martykulma approved these changes Feb 24, 2026
View reviewed changes
Copy link
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🦈

@petrosagg petrosagg enabled auto-merge (squash) February 25, 2026 10:09
@petrosagg petrosagg merged commit 84b2975 into MaterializeInc:main Feb 25, 2026
135 checks passed
@petrosagg petrosagg deleted the commmit-to-rlu branch February 25, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teskje teskje teskje approved these changes

@martykulma martykulma martykulma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petrosagg @teskje @martykulma