Separate instance_client and more precise error types#34839
Open
ggevay wants to merge 3 commits intoMaterializeInc:mainfrom
Open
Separate instance_client and more precise error types#34839ggevay wants to merge 3 commits intoMaterializeInc:mainfrom
instance_client and more precise error types#34839ggevay wants to merge 3 commits intoMaterializeInc:mainfrom
Conversation
ggevay
added
A-controller
ggevay
force-pushed
the
instance_client-refactoring
branch
from
b9f1c71 to
cade330
Compare
ggevay
changed the title
instance_clientinstance_client and more precise error types
ggevay
force-pushed
the
instance_client-refactoring
branch
3 times, most recently
from
61efcbb to
cccab47
Compare
ggevay
force-pushed
the
instance_client-refactoring
branch
2 times, most recently
from
879eebb to
ef2a3ce
Compare
ggevay
force-pushed
the
instance_client-refactoring
branch
from
ef2a3ce to
8cc1475
Compare
ggevay
requested review from
SangJunBak,
antiguru and
teskje
and removed request for
SangJunBak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring related to the frontend peek sequencing, addressing the second paragraph of #33713 (comment) + other related discussions with Moritz and Jan.
It's split into commits meaningfully. (I could also split it up to into multiple PRs if desired.)
The first commit is just code movement, moving out the
Clientfrominstance.rsinto a new fileinstance_client.rs, and renaming it toInstanceClient. (This is used by the frontend peek sequencing directly, bypassing theComputeController, because we don't want the Coordinator to be a bottleneck for fast-path peeks.)The second commit makes many function return types specify more precise error types. This made
CollectionLookupErrorused only byPeekClient, so I moved it there.The third commit just resolves some of the
/// TODO(database-issues#7533): Add documentation.comments incontroller/error.rs.