fix: stop coverage without start#4947
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #3991 by ensuring Stop Coverage behaves correctly (and logs accurately) when coverage was never started for the active page, avoiding misleading “report generated” behavior.
Changes:
- Node side returns a sentinel body (
ROBOT_FRAMEWORK_BROWSER_NO_SET) when stopping coverage without a prior start. - Python keyword
stop_coveragedetects that sentinel, logs that no report was generated, and returnsNone. - Adds an acceptance test covering the “only stop coverage” scenario and verifying the expected logs and return value.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| node/playwright-wrapper/playwright-state.ts | Returns a sentinel value instead of an empty string when coverage was not started. |
| Browser/keywords/coverage.py | Interprets the sentinel, logs “no report generated”, and returns None. |
| atest/test/01_Browser_Management/coverage.robot | Adds an acceptance test validating logs and ${None} return when only Stop Coverage is called. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3991