Update to version 1.4.0 - Eraser tool, enable/disable DrawController, add background content, fix onTap#8
Open
CyrusCastle wants to merge 9 commits intoMarkYav:masterfrom
Open
Update to version 1.4.0 - Eraser tool, enable/disable DrawController, add background content, fix onTap#8CyrusCastle wants to merge 9 commits intoMarkYav:masterfrom
CyrusCastle wants to merge 9 commits intoMarkYav:masterfrom
Conversation
… Modifiers should really come unmodified by default
Owner
|
Hello @CyrusCastle! Happy to hear that the library was useful for you. I will check the PR and update the release. Just to set expectations, my availability is limited right now, so this process will realistically take some time. I really liked your idea about passing a composable function as a parameter! It is a more general approach, allowing more flexibility for future users. I am thinking about using this approach instead of The idea of enabling/disabling input processing is also interesting. And thank you for fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I really appreciate this little library, I'm currently using it in a KMP project of mine working with Farsi handwriting. I needed a way to actively enable/disable DrawController based on certain conditions, and to show the user a hint of how to draw the particular character they're working with.
Hence this PR.
I thought it'd be helpful if I implemented the eraser tool for you while I was there ^^
Changes: