Migrate graders_manager.jsx to React Table V8#8002
Open
mrafie1 wants to merge 7 commits into
Open
Conversation
…Updated filter.jsx to account for new component
… migrate-GradersManager
Collaborator
Coverage Report for CI Build 27473346421Coverage decreased (-0.05%) to 90.162%Details
Uncovered Changes
Coverage Regressions4 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
tablefolder to include case sensitive filtering along side searching:case_sensitive_search_filterfilter.jsxto allow this component to be displayed when filterVariant: "case-sensitive-text" is usedsearch_filter.jsxaria-label definitionI18n.t("table.search")column.columnDef.headerfull_namecolumn usessearch_filter.jsxfor its search bar component. However, previous tests forgraders_manager.tsxexpected a search bar with the qualities:{name: ${I18n.t("search")} Name. With the previous definition, only the aria-label${I18n.t("search")}appears when runningscreen.debug(). Mimicking the previous implementation forcaseSensitiveTextFilterintable_helpers.jsx, allows all frontend tests to run and fixes the missing information in the aria-label.getSelectedRows()andresetSelection()<Table>isCaseSensitiveattribute to statetoggleCaseSensitivityfunction togroup_namecolumn's meta-section to allow the filter component to update caseSensitivity.Screenshots of your changes (if applicable)
BeforeAfter
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
Small Note:
filter.jsxinsteadVery important question:
<Table>componentinitialStatedefinition means that they cannot change, even if the props being passed in are changing (Correct me if I'm wrong).Please feel free to ask about a specific component. I ended up removing many of the previous functions to make my implementation more similar to Lizzie's and to 'mock' the functionality of the previous implementation.
Am I good to start migrating the Annotations table? I'm kind of interested in pursuing another part of the codebase/doing something different. I'll let you know if I have anything specific in mind.