MDEV-39265: Assertion (mem_root->flags & 4) == 0 failed upon 2nd execution USING DEFAULT with sequence#4926
Open
raghunandanbhat wants to merge 1 commit into10.6from
Open
MDEV-39265: Assertion (mem_root->flags & 4) == 0 failed upon 2nd execution USING DEFAULT with sequence#4926raghunandanbhat wants to merge 1 commit into10.6from
(mem_root->flags & 4) == 0 failed upon 2nd execution USING DEFAULT with sequence#4926raghunandanbhat wants to merge 1 commit into10.6from
Conversation
…ecution `USING DEFAULT` with sequence Problem: When a prepared statement uses `DEFAULT` with sequence, on its second or subsequent execution, server tries to allocate TABLE_LIST object (used for adding sequence table to `internal_tables` list) on statement's memory root. This fails with an assert because statement's memory root is marked read-only after the first execution. CREATE SEQUENCE s; CREATE TABLE t (a INT DEFAULT(NEXTVAL(s))); PREPARE stmt FROM "UPDATE t SET a = ?"; EXECUTE stmt USING 3; -- first execution, marks mem_root read-only EXECUTE stmt USING DEFAULT; -- tries to allocate on second execution Fix: Temporarily clear the read-only flag on the statement memory root to allow the allocation. Also adds a debug hook to verify allocation happens not more than once per prepared statement and per internal table added to the list.
cb765fd to
a6ff6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MDEV-39265
Problem:
When a prepared statement uses
DEFAULTwith sequence, on its second or subsequent execution, server tries to allocateTABLE_LISTobject (used for adding sequence table tointernal_tableslist) on statement's memory root. This fails with an assert because statement's memory root is marked read-only after the first execution.Fix:
Temporarily clear the read-only flag on the statement memory root to allow the allocation. Also adds a debug hook to verify allocation happens not more than once per prepared statement and per internal table added to the list.