MDEV-38878 Archive index_read_idx function isn't virtual#4670
Open
grooverdan wants to merge 1 commit intoMariaDB:11.4from
Open
MDEV-38878 Archive index_read_idx function isn't virtual#4670grooverdan wants to merge 1 commit intoMariaDB:11.4from
grooverdan wants to merge 1 commit intoMariaDB:11.4from
Conversation
index_read_idx cannot be a virtual function in a final class. The use of a index_read_idx function by the SQL layer was removed long ago. The remaining use is from index_read, that uses active_index as the argument to index when calling index_read_idx. So we simply collapse index_read_idx into index_read. The index_read declaration also doesn't require virtual, the "override" make it explict that its overriding a parent class implementation.
grooverdan
added
the
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index_read_idx cannot be a virtual function in a final class.
The use of a index_read_idx function by the SQL layer was removed long ago.
The remaining use is from index_read, that uses active_index as the argument to index when calling index_read_idx.
So we simply collapse index_read_idx into index_read.
The index_read declaration also doesn't require virtual, the "override" make it explicit that its overriding a parent class implementation.