Skip to content
/ server Public

Comments

MDEV-29466: Rename description_event_for_exec to description_event_for_sql_thread#4668

Open
ChandanaRamakrishna wants to merge 1 commit intoMariaDB:10.6from
ChandanaRamakrishna:MDEV-29466-rename-description-event-10.6
Open

MDEV-29466: Rename description_event_for_exec to description_event_for_sql_thread#4668
ChandanaRamakrishna wants to merge 1 commit intoMariaDB:10.6from
ChandanaRamakrishna:MDEV-29466-rename-description-event-10.6

Conversation

@ChandanaRamakrishna
Copy link

Renamed description_event_for_exec to description_event_for_sql_thread
for clarity, since it is used by the SQL thread.

No functional changes.

Based on 10.6 as requested.

@gkodinov gkodinov added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Feb 20, 2026
Copy link
Member

@gkodinov gkodinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preliminary review. Thank you for rebasing this to 10.6.

Please update your commit's text so that it complies to CODING_STANDARDS.md.

…_sql_thread

Pure rename for clarity. No functional changes.
@ChandanaRamakrishna ChandanaRamakrishna force-pushed the MDEV-29466-rename-description-event-10.6 branch from b06759a to ad7bc15 Compare February 20, 2026 09:44
@ChandanaRamakrishna
Copy link
Author

Updated the commit message to comply with CODING_STANDARDS.md.
Please let me know if anything else needs adjustment.

Copy link
Member

@gkodinov gkodinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. thanks.

@ChandanaRamakrishna
Copy link
Author

ChandanaRamakrishna commented Feb 20, 2026 via email

@gkodinov gkodinov requested a review from andrelkin February 20, 2026 11:26
@andrelkin
Copy link
Contributor

Dear Chandana, thanks for a good piece of help!

I am sorry not to have made it clear earlier that the patch would be better off to go to 13.0.
At this point it fits more to refactoring and can't be anyway disturbing to those who deeply rooted to the old name,
while also at fixing functional bugs.

If you don't mind, could you please rebase your work onto the current main branch?

Cheers,
Andrei

@ChandanaRamakrishna
Copy link
Author

ChandanaRamakrishna commented Feb 22, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.

Development

Successfully merging this pull request may close these issues.

3 participants