MDEV-29466: Rename description_event_for_exec to description_event_for_sql_thread#4668
Open
ChandanaRamakrishna wants to merge 1 commit intoMariaDB:10.6from
Open
Conversation
gkodinov
requested changes
Feb 20, 2026
Member
gkodinov
left a comment
There was a problem hiding this comment.
This is a preliminary review. Thank you for rebasing this to 10.6.
Please update your commit's text so that it complies to CODING_STANDARDS.md.
…_sql_thread Pure rename for clarity. No functional changes.
b06759a to
ad7bc15
Compare
Author
|
Updated the commit message to comply with CODING_STANDARDS.md. |
Author
|
Thank you for the review!
…On Fri, 20 Feb 2026 at 16:33, Georgi Kodinov ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM now. thanks.
—
Reply to this email directly, view it on GitHub
<#4668 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UGWV4FSLIA3TDHLDSL4M3SXFAVCNFSM6AAAAACVW3J6CKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMZRGQ2TKNBQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Dear Chandana, thanks for a good piece of help! I am sorry not to have made it clear earlier that the patch would be better off to go to 13.0. If you don't mind, could you please rebase your work onto the current main branch? Cheers, |
Author
|
Hi Andrei,
I have rebased the change onto current main and applied the rename directly
there.
Please let me know if any further adjustments are needed.
Thanks!
…On Fri, 20 Feb 2026 at 17:18, andrelkin ***@***.***> wrote:
*andrelkin* left a comment (MariaDB/server#4668)
<#4668 (comment)>
Dear Chandana <https://github.com/ChandanaRamakrishna>, thanks for a good
piece of help!
I am sorry not to have made it clear earlier that the patch would be
better off to go to 13.0.
At this point it fits more to refactoring and can't be anyway disturbing
to those who deeply rooted to the old name,
while also at fixing functional bugs.
If you don't mind, could you please rebase your work onto the current main
branch?
Cheers,
Andrei
—
Reply to this email directly, view it on GitHub
<#4668 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UDFH7CVH2RDRDUDKNT4M3YBHAVCNFSM6AAAAACVW3J6CKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMZTGUZTCNZTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed description_event_for_exec to description_event_for_sql_thread
for clarity, since it is used by the SQL thread.
No functional changes.
Based on 10.6 as requested.