MDEV-38855 Remove obsolete compiler version checks from storage/rocksdb/CMakeLists.txt#4663
Open
ChandanaRamakrishna wants to merge 2 commits intoMariaDB:mainfrom
Open
Conversation
…Lists.txt Assume: - GCC >= 7 - Clang >= 10 - CMake >= 3.12 Remove: - GCC < 4.8 and < 5.0 checks - Clang < 3.3 checks - CMake < 3.0 fallback logic - Manual -std=c++11 flag handling Use CMAKE_CXX_STANDARD for C++11 configuration.
|
|
gkodinov
added
the
External Contribution
gkodinov
changed the title
Member
|
Since this is not the full MDEV-35462 I've created a sub-task of it and added the contribution to it. |
gkodinov
approved these changes
Feb 18, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution. LGTM. Note that this is a preliminary review. Please wait for the final reviewer assignment.
vuvova
changed the title
vuvova
changed the title
vuvova
changed the title
dr-m
requested changes
Feb 18, 2026
Author
|
Removed the MSVC_VERSION check as suggested. Leaving the clang-cl check
pending your review.
…On Wed, 18 Feb 2026 at 15:39, Vladislav Vaintroub ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In storage/rocksdb/CMakeLists.txt
<#4663 (comment)>:
> + if (MSVC_VERSION LESS 1900)
SKIP_ROCKSDB_PLUGIN("${OLD_COMPILER_MSG}")
So please, proceed remove MSVC version check. But about clang-cl I do not
know, I'll check.
—
Reply to this email directly, view it on GitHub
<#4663 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UCHU5CQTIJYUNEWD734MQ26FAVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJYHE2TOMRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ChandanaRamakrishna
force-pushed
the
MDEV-35462-part1-rocksdb
branch
from
d05d965 to
50498a9
Compare
Author
|
Removed unnecessary -fPIC for MSVC and adjusted the clang-cl handling as
suggested. Please take another look.
…On Wed, 18 Feb 2026 at 16:58, Vladislav Vaintroub ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In storage/rocksdb/CMakeLists.txt
<#4663 (comment)>:
> + if (MSVC_VERSION LESS 1900)
SKIP_ROCKSDB_PLUGIN("${OLD_COMPILER_MSG}")
clang-cl compiles, but complains about unnecessary -fPIC, added for
whatever purpose here
https://github.com/MariaDB/server/blob/main/storage/rocksdb/build_rocksdb.cmake#L548
So, maybe you can remove both the unnecessary -fPIC and the clang-cl check
as well?
—
Reply to this email directly, view it on GitHub
<#4663 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UHN35NUROFYH65JQID4MREHNAVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJZGMZTENBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
vaintroub
reviewed
Feb 18, 2026
storage/rocksdb/build_rocksdb.cmake
Outdated
| COMPILE_FLAGS "-fno-builtin-memcmp -Wno-error") | ||
| ELSE() | ||
| SET_TARGET_PROPERTIES(rocksdblib PROPERTIES | ||
| COMPILE_FLAGS "-fPIC -fno-builtin-memcmp -Wno-error") |
Member
There was a problem hiding this comment.
Just remove that -fPIC always from the above line. Always, not just for clang-cl. For everything. no need for more IF. No need for more -fPICs . ADD_CONVENIENCE_LIBRARY above adds that if needed.
ChandanaRamakrishna
force-pushed
the
MDEV-35462-part1-rocksdb
branch
from
50498a9 to
554aa7f
Compare
vaintroub
approved these changes
Feb 18, 2026
Member
vaintroub
left a comment
vaintroub
left a comment
There was a problem hiding this comment.
I'm ok with that.
I would not split lines in SET_TARGET_PROPERTIES in build_rocksdb.cmake, those are not too long, but no strong opinions . It is probably VSCode that formats that for you?
…Lists.txt per review
ChandanaRamakrishna
force-pushed
the
MDEV-35462-part1-rocksdb
branch
from
554aa7f to
ba107e1
Compare
Author
|
Thanks for pointing that out.
Yes, that was VSCode formatting — I’ve restored it to a single line.
…On Wed, 18 Feb 2026 at 19:16, Vladislav Vaintroub ***@***.***> wrote:
***@***.**** approved this pull request.
I'm ok with that.
I would not split lines in SET_TARGET_PROPERTIES in build_rocksdb.cmake,
those are not too long, but no strong opinions . It is probably VSCode that
formats that for you?
—
Reply to this email directly, view it on GitHub
<#4663 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UHVV3ZECT7D6MXRJJL4MRUK3AVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMRQGAYDENRSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dr-m
approved these changes
Feb 19, 2026
ParadoxV5
reviewed
Feb 21, 2026
Contributor
There was a problem hiding this comment.
o: This will resolve MDEV-38213 Upgrade RocksDB to C++17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of MDEV-35462, removing obsolete compiler version checks.
Changes
Simplified
storage/rocksdb/CMakeLists.txtby removing:Replaced with modern
CMAKE_CXX_STANDARDconfiguration.Confirmed Minimums
As confirmed by @marko:
Use CMAKE_CXX_STANDARD for C++11 configuration.
Related
No functional changes intended.