MDEV-27837: Disallow SET @@session.server_id within transaction#4660
Open
shabbann wants to merge 2 commits intoMariaDB:10.6from
Open
MDEV-27837: Disallow SET @@session.server_id within transaction#4660shabbann wants to merge 2 commits intoMariaDB:10.6from
shabbann wants to merge 2 commits intoMariaDB:10.6from
Conversation
Setting server_id within a transaction is dangerous for replication. Added check_not_in_transaction validation to server_id variable.
gkodinov
added
the
External Contribution
gkodinov
requested changes
Feb 17, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution. This is a preliminary review. Once this is done I will solicit a final review on this.
- Add specific error codes ER_CANT_SET_SERVER_ID_IN_TRANSACTION and ER_CANT_SET_SERVER_ID_IN_SUBSTATEMENT - Extend test to cover trigger and stored procedure cases
gkodinov
approved these changes
Feb 18, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your quick fixes! Stand by for the final review please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting server_id within a transaction is dangerous for replication as it
can cause events to be filtered incorrectly on the replica, especially in
parallel replication mode.
This patch adds a check to prevent SET @@session.server_id from being
executed while a transaction is active