MDEV-38842 Server fails to drop .ibd file when vector table creation fails#4659
Open
Thirunarayanan wants to merge 1 commit into11.8from
Open
MDEV-38842 Server fails to drop .ibd file when vector table creation fails#4659Thirunarayanan wants to merge 1 commit into11.8from
Thirunarayanan wants to merge 1 commit into11.8from
Conversation
…fails Problem: ======== When creating tables with vector indexes, if the secondary table creation fails after the main table is successfully created, the server was not properly cleaning up the main table's .ibd file. Stale file exists because create_table_impl() always called ddl_log_complete() on any error, which disables DDL log entries instead of executing them for cleanup. The main table would be left behind even though the overall CREATE TABLE operation failed. Solution: ========= ha_create_table(): Return error code 2 specifically when secondary table creation for high-level indexes fails create_table_impl(): Call ddl_log_revert() when error code is 2 to properly clean up the main table files.
|
|
Contributor
|
I don’t think I can review this, because the changes are outside InnoDB and I wasn’t involved in the design, implementation, or review of MDEV-32887 Vector Search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When creating tables with vector indexes, if the secondary table creation fails after the main table is successfully created, the server was not properly cleaning up the main table's .ibd file. Stale file exists because create_table_impl() always called ddl_log_complete() on any error, which disables DDL log entries instead of executing them for cleanup. The main table would be left behind even though the overall CREATE TABLE operation failed.
Solution:
ha_create_table(): Return error code 2 specifically when secondary table creation for high-level indexes fails
create_table_impl(): Call ddl_log_revert() when error code is 2 to properly clean up the main table files.