Skip to content
/ server Public

Comments

MDEV-7270: Fix replicas not honoring slave_skip_errors for 1677#4653

Open
OmarGamal10 wants to merge 4 commits intoMariaDB:10.6from
OmarGamal10:mdev-7270
Open

MDEV-7270: Fix replicas not honoring slave_skip_errors for 1677#4653
OmarGamal10 wants to merge 4 commits intoMariaDB:10.6from
OmarGamal10:mdev-7270

Conversation

@OmarGamal10
Copy link

@OmarGamal10 OmarGamal10 commented Feb 15, 2026 •
edited
Loading

Summary

  • This PR fixes replicas crashing on column type mismatch for row-based replication, not honoring the slave_skip_errors configuration.
  • The issue comments on JIRA pointed to an upstream (mysql) test, which was helpful for tracking the bug and eventually implementing the fix.
  • The replica now skips the event gracefully (in case the error is actually caught and the column is not convertible), logs a warning and does not abort.

Fix: MDEV-7270

Note: binlog_base64_flag.test uses the log_event_old.cc and not the current log_event_server.cc. Not sure why that is but it was causing a test failure.

@OmarGamal10
MDEV-7270: Fix replicas not honoring slave_skip_errors for 1677
6942fac 
Setting slave_skip_errors to 1677 (ER_SLAVE_CONVERSION_FAILED) results in slaves ignoring the configruation and aborting replication on a column mismatch.
The intended behaviour should logically be ignoring the event and logging a warning.
@OmarGamal10
Add an enum for Row master-slave compatibility for cleaner handling
6050f1d
@ParadoxV5 ParadoxV5 requested a review from bnestere February 15, 2026 18:13
@gkodinov gkodinov added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnestere bnestere Awaiting requested review from bnestere

Assignees

No one assigned

Labels

External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OmarGamal10 @gkodinov