MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle#4649
MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle#4649Mahmoud-kh1 wants to merge 2 commits intoMariaDB:12.3from
Conversation
9c29faa to
d649859
Compare
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution. This is a preliminary review.
Couple of things:
- Please add a better commit message that according to the coding standard: describes what the issue is, how it was fixed and how it was tested.
- I do not see the CLA bot confirmation. Please rectify this
- I would add some HEX codes into the tests to make sure the relevant encoded texts (day names) are spelled correctly.
d649859 to
481e77c
Compare
481e77c to
6cc4a25
Compare
… Nulls Issue: Wrong months names and days was written in Arabic instead of Urdu caused TO_DATE() parsing failures. Fix: Update months names and days to be standard Urdu. Test: Added tests to verfiy the fix also with HEX validation.
6cc4a25 to
efcf404
Compare
gkodinov
left a comment
There was a problem hiding this comment.
Thank you! LGTM. Please stand by for the final review.
abarkov
left a comment
There was a problem hiding this comment.
The patch looks correct for me.
The new locale data matches Unicode Locale Data at:
https://github.com/unicode-org/cldr/blob/main/common/main/ur.xml
Can you please backport the patch to 12.3, so we merge it into the earliest version which supports TO_DATE() - since 12.3.1.
Another option would be to backport to 10.6, but this will need rewritting tests using STR_TO_DATE() instead of TO_DATE().
Thanks.
done , I backport it to 12.3 |

The problem :

previously, TO_DATE() would return NULL when using Urdu month or day names
The bug :

I found the bug is a mismatch for certain characters in days and months
Key changes :
Now it works as intended

issue ID:
MDEV-38583