fix: fall back to src-relative snk when SolutionDir is unset (#848)#978
Open
leno23 wants to merge 1 commit into
Open
fix: fall back to src-relative snk when SolutionDir is unset (#848)#978leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…Mapper#848) Allow `dotnet test path/to/csproj` to resolve the shared assembly key from Directory.Build.props via MSBuildThisFileDirectory when SolutionDir is not provided by the build. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #848.
Directory.Build.propsalways referenced$(SolutionDir)/Mapster/Mapster.snk, butSolutionDiris not set when building/testing a single project directly (for exampledotnet test src/Mapster.DependencyInjection.Tests/Mapster.DependencyInjection.Tests.csproj).This adds a fallback to
$(MSBuildThisFileDirectory)Mapster/Mapster.snk, which resolves correctly fromsrc/Directory.Build.props.Changes
src/Directory.Build.props: conditionally pick the signing key fromSolutionDirwhen available, otherwise from the props file directory.Test plan
developmentdotnet test src/Mapster.DependencyInjection.Tests/Mapster.DependencyInjection.Tests.csprojsucceeds without passing-property:SolutionDir=...SolutionDiris setMade with Cursor