fix: support CompileProjection with Include on abstract types (#801)#977
Open
leno23 wants to merge 1 commit into
Open
fix: support CompileProjection with Include on abstract types (#801)#977leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…rMapper#801) Generate TypeIs-based conditional projection expressions when mapping abstract destination hierarchies with Include, and harden inline class mapping when instantiation cannot produce a NewExpression. Also add regression coverage for not-self-creation types inside containing classes (MapsterMapper#911). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #801 and adds regression coverage for #911.
CompileProjection()on abstract base mappings with.Include()previously failed withInvalidCastExceptionbecause inline projection tried to cast aThrow/UnaryExpressiontoNewExpression. The adapter now buildsTypeIs-based conditional projection expressions for included derived types.JsonDocumentandUrimap correctly when nested inside containing classes (direct same-type mapping was already covered).Changes
ClassAdapter.CreateInlineExpression: handle abstract destination +Includefor projection; avoid invalidNewExpressioncast when instantiation is impossible.ClassAdapter.CreateIncludeProjectionExpression: new helper mirroring runtime include redirect semantics for EF-translatable projection.WhenIncludeDerivedClassesandWhenMappingRecordRegression.Test plan
developmentCompileProjection_Including_Derived_Classcompiles without exceptionNotSelfCreationTypeMappingInContainingClassWithoutErrorpassesMade with Cursor