fix: cast inherited MapWith results to derived destinations (#947)#976
Open
leno23 wants to merge 1 commit into
Open
fix: cast inherited MapWith results to derived destinations (#947)#976leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…apper#947) When AllowImplicitDestinationInheritance merges a base MapWith converter into a derived destination mapping, downcast the converter result so Adapt<TDerived>() no longer throws InvalidCastException. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #947.
When
AllowImplicitDestinationInheritanceis enabled and a base mapping usesMapWith(returning the base destination type), callingAdapt<TDerived>()previously compiled a converter whose return type was the base type, causing anInvalidCastExceptionat runtime even when the factory actually created a derived instance.This adjusts the compiled converter to downcast the
MapWithresult to the requested derived destination type.Changes
TypeAdapterConfig.CreateMapExpression: addAdjustInheritedConverterReturnTypeto cast inheritedMapWithresults when the configured return type is a base of the requested destination.Adapt<Dog>()andAdapt<AnimalDto, Dog>()for the reported scenario.Test plan
developmentWhenImplicitInheritanceMapWithDerivedDestinationpassMade with Cursor