fix: apply custom Map results when mapping to existing target (#900)#970
Open
leno23 wants to merge 1 commit into
Open
fix: apply custom Map results when mapping to existing target (#900)#970leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…rMapper#900) MapToTarget was passing the existing destination member into nested adaptation even when a custom .Map() resolver already computed the final value, causing immutable/getter-only member values to be preserved. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapToTarget(mapper.Map(dto, existingEntity)) ignoring custom.Map()resolvers when the destination member already has a value..Map()configuration, skip passing the existing destination member into nested adaptation so the resolver result is assigned directly.Root cause
For
MapToTarget,ClassAdapteralways passed the existing destination member expression intoCreateAdaptExpression. That triggered nestedMapToTargetadaptation for the member type. For immutable/getter-only types (like primary-constructor classes), nested mapping preserves the existing destination instance instead of replacing it with the custom.Map()result.Test plan
Mapster.TestsWhenMappingGetterOnlyMapToTargetRegression.MapToTarget_WithCustomMap_ShouldReplaceExistingDestinationMemberValueFixes #900
Made with Cursor