Allow draggable.start to cancel a drag#338
Open
aminer-looker wants to merge 1 commit intoManifestWebDesign:masterfrom
Open
Allow draggable.start to cancel a drag#338aminer-looker wants to merge 1 commit intoManifestWebDesign:masterfrom
draggable.start to cancel a drag#338aminer-looker wants to merge 1 commit intoManifestWebDesign:masterfrom
Conversation
For some uses, the user shouldn't be able to initiate a drag from just anywhere within the gridster item element or under certain changable conditions. The current implementation offers no way for the end user to exert such control over dragging. This change allows end users to cancel a drag by returning the string "cancel" from their `draggable.start` function. Any other return value will allow the drag to continue. Other API interfaces would be better (e.g., return `true` to start the drag and `false` to cancel), but any API which requires a specific to continue the drag would not be backward compatible. This solution only looks for a specific value, and only invokes the new functionality in that case.
Member
|
Nice! Question: why return |
Author
|
It's been a while since I wrote this, but if I recall correctly, a falsy value was already being interpreted to mean that everything was okay, so I couldn't use that. I needed to return some other value which indicated the callback wanted to cancel the operation, so... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some uses, the user shouldn't be able to initiate a drag from
just anywhere within the gridster item element or under certain
changable conditions. The current implementation offers no way for
the end user to exert such control over dragging.
This change allows end users to cancel a drag by returning the string
"cancel" from their
draggable.startfunction. Any other returnvalue will allow the drag to continue.
Other API interfaces would be better (e.g., return
trueto startthe drag and
falseto cancel), but any API which requires aspecific to continue the drag would not be backward compatible. This
solution only looks for a specific value, and only invokes the new
functionality in that case.