Fix for issues #182 #292 and added new feature 'locking'#303
Open
chinchiheather wants to merge 32 commits intoManifestWebDesign:masterfrom
Open
Fix for issues #182 #292 and added new feature 'locking'#303chinchiheather wants to merge 32 commits intoManifestWebDesign:masterfrom
chinchiheather wants to merge 32 commits intoManifestWebDesign:masterfrom
Conversation
…ag event if draggable turned off for widget
… item is positioned only where it can be fitted in. Code is pretty rough, needs tidying up, etc.
…st space after portlet. Don't dispatch gridster-item-removed event on destroy
…ag event if draggable turned off for widget
… item is positioned only where it can be fitted in. Code is pretty rough, needs tidying up, etc.
…st space after portlet. Don't dispatch gridster-item-removed event on destroy
Conflicts: dist/angular-gridster.min.css dist/angular-gridster.min.js src/angular-gridster.js
|
Hi @chinchiheather, |
Author
|
Hi @maximou4391 you can set boolean properties "resizable" and "draggable" on each gridster item you pass to the gridster Something like: <div gridster>
<ul>
<li gridster-item="{ row: 0, col: 5, draggable: false, resizable: false }">
<div>gridster item content</div>
</li>
</ul>
</div> |
added 4 commits
October 19, 2015 17:37
…en item added successfully. If an item doesn't fit, now shrink it down and try to fit it in.
|
Hi, @chinchiheather, the draggable=false does not seem to work for me. Any workaround? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have done a few things here:
I implemented a fix for issue #182 so you can set boolean draggable/resizable properties (default true) per widget, so you can prevent individual widgets from being resized or dragged.
I found a solution to the issue I raised #292.
I also something else that I found I wanted - so I added a new config option called locking which works in the same way as pushing, floating, swapping. If locking is set to true it means that items will not get pushed out of the way to make room for new items, but that the new item will have to find the next available space.
I've never made a pull request before on github so hopefully I didn't do anything wrong, and I think my version number has gone a bit too high, but I needed that so bower knew there was a new version to download. Anyway... hope it's okay, thanks!