Skip to content

fix systeminformation thread not ending#4155

Merged
KristjanESPERANTO merged 1 commit into
MagicMirrorOrg:developfrom
khassel:sysinfo
May 18, 2026
Merged

fix systeminformation thread not ending#4155
KristjanESPERANTO merged 1 commit into
MagicMirrorOrg:developfrom
khassel:sysinfo

Conversation

@khassel
Copy link
Copy Markdown
Collaborator

@khassel khassel commented May 16, 2026

This was introduced when running systeminformation in an own thread.

If the main thread ends before (e.g. when config has errors) the systeminformation thread never ends.

As this can have side effects under pm2 or docker (because the app never exits) this PR restores the old behavior.

@khassel khassel marked this pull request as draft May 16, 2026 21:54
Copy link
Copy Markdown
Collaborator

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution 👍 Why is this still a draft?

@khassel
Copy link
Copy Markdown
Collaborator Author

khassel commented May 17, 2026

it still does not work ...

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

If you need help with further investigation: How are you reproducing the issue? I'm having trouble seeing it on my end - Worker threads die with the parent process, so no orphans under pm2.

@khassel
Copy link
Copy Markdown
Collaborator Author

khassel commented May 17, 2026

as always within a container. This PR solves the problem where threads are not ending but systeminfo is not displayed ... will try again later or tomorrow.

Which setup did you test with pm2 (with this PR or without or both)?

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

Both, but now I see the issue with the missing output when the config has an error, but no approach to solve it.
Is the systeminfo really relevant in that situation?

@khassel
Copy link
Copy Markdown
Collaborator Author

khassel commented May 17, 2026

I have now an ugly approach to solve it ...

Copy link
Copy Markdown
Collaborator

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's that ugly. Since I don't see a better approach I'm okay with this one :)

@khassel khassel marked this pull request as ready for review May 18, 2026 17:39
@KristjanESPERANTO KristjanESPERANTO merged commit 3c514df into MagicMirrorOrg:develop May 18, 2026
12 checks passed
@khassel khassel deleted the sysinfo branch May 18, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants