Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the M-VAVE SMK25-II midi controller.
https://www.cuvave.com/productinfo/1106099.html
The controller has 25 keys, 16 pads, 8 knobs, built-in arpeggiator and smart chords, MCP function, octave control and two sliders. The sliders are setup for pitch bend and mod, respectively. The octave control is built-in and not programmable, same with the arpeggiator and smart chord functions. The MCP button "toggles" a new layer for the drum pad, and both layers are programmable.
I used the factory settings from the controller to add support for it. I thought of adding transport controls, as the 2nd row of the drum pad has some control labels on it, but it requires changing the controller's mappings using the official software.
I haven't tested the sustain pedal function as I don't own a pedal.
The name detection may be different as well, as I haven't tested it on Windows (only on Linux).
Happily taking any suggestions to improve support for this keyboard, as it's my first time using a MIDI keyboard with a DAW.