Conversation
…ptimization-problems' of github.com:MachineLearningLifeScience/poli into 255-implement-set-of-dms-experiment-results-as-static-optimization-problems
|
Currently testing broken, with:
Even though objectives have been registered. |
|
Test functions passing now. |
|
|
||
| Raises: | ||
| ------- | ||
| ... |
There was a problem hiding this comment.
You could remove this, I assume.
| for x_i in x: | ||
| # Assuming x_i is an array of strings | ||
| if len(x_i) != 4: | ||
| raise ValueError("Inputs of L=4 expected!") |
There was a problem hiding this comment.
Maybe add a little bit more information in this error (e.g. current length len(x_i) and position i)?
|
|
||
| Raises: | ||
| ------- | ||
| ... |
There was a problem hiding this comment.
Same here, you could remove this I imagine.
miguelgondu
left a comment
miguelgondu
left a comment
There was a problem hiding this comment.
Some minor changes, but otherwise looks good!
|
Removed empty docstring portions. Added more context to ValueErrors on incorrect inputs. |
RMichae1
deleted the
255-implement-set-of-dms-experiment-results-as-static-optimization-problems
branch
2 participants
Added DMS experiments for GB1 and TrpB.
Implemented as static lookup against table of
fitness.csvassets.