Fix stop parameter check to allow explicit None value#2482
Open
sam-baumann wants to merge 1 commit intoMaartenGr:masterfrom
Open
Fix stop parameter check to allow explicit None value#2482sam-baumann wants to merge 1 commit intoMaartenGr:masterfrom
sam-baumann wants to merge 1 commit intoMaartenGr:masterfrom
Conversation
Previously, `not self.generator_kwargs.get("stop")` would overwrite a
user-supplied `stop=None` (which disables the stop sequence). Use `"stop"
not in` to only set the default when the key is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
not self.generator_kwargs.get("stop")would overwrite a user-suppliedstop=None(which disables the stop sequence). Use"stop" not into only set the default when the key is absent.Thinking models, at least gemma4:e2b in Ollama, will stop their reasoning chain on
\neven if they shouldn't complete, so this gives a way to overwrite thatWhat does this PR do?
checks if "stop" is a member of the
generator_kwargsdict instead of just checking it as a boolean, as passing inNonecaused it to evaluate toFalseand it setsstopas\nanywayFixes #2481
Before submitting