Add debris friction test with MISMIP+#938
Open
matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
Open
Add debris friction test with MISMIP+#938matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
matthewhoffman wants to merge 3 commits intoMPAS-Dev:mainfrom
Conversation
Also add it to the full integration suite
* shorten smoke test length * add fallback for core_per_node
matthewhoffman
added
land ice
in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new MALI test for the new debris friction law capability. It uses the MISMIP+ test case as a smoke test. It also adds that test to the full_integration suite, as well as the standard MISMIP+ test. The debris friction law is added as a variant to the standard MISMIP+ smoke test, and uses preset parameter values that get added the standard initial condition file.
Checklist
api.rst) has any new or modified class, method and/or functions listedMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes